From 055290e555cb87e1e1207b12fa55f4dcd7588456 Mon Sep 17 00:00:00 2001
From: Christoph <ckubu@oopen.de>
Date: Tue, 10 Mar 2026 11:09:25 +0100
Subject: [PATCH] Update: Replace deprecated ansible_os_family with
 ansible_facts.os_family

- x2go-server.yml: Updated condition to use ansible_facts.os_family
- upgrade.yml: Updated all conditions and commented lines
- caching-nameserver.yml: Updated RedHat OS family checks

Fixes deprecation warning in Ansible 2.12+
---
 roles/common/tasks/caching-nameserver.yml |  4 ++--
 roles/common/tasks/x2go-server.yml        |  5 +++--
 upgrade.yml                               | 12 ++++++------
 3 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/roles/common/tasks/caching-nameserver.yml b/roles/common/tasks/caching-nameserver.yml
index dcc4cc9..f8b34af 100644
--- a/roles/common/tasks/caching-nameserver.yml
+++ b/roles/common/tasks/caching-nameserver.yml
@@ -60,7 +60,7 @@
     update_cache: yes
     #cache_valid_time: 3600
   when:
-    - ansible_os_family == "RedHat"
+    - ansible_facts.os_family == "RedHat"
     - ansible_facts["distribution"] == "CentOS"
   tags:
     - yum-update
@@ -70,7 +70,7 @@
     name: "{{ yum_bind_pks }}"
     state: "{{ yum_install_state }}"
   when:
-    - ansible_os_family == "RedHat"
+    - ansible_facts.os_family == "RedHat"
     - ansible_facts["distribution"] == "CentOS"
   tags:
     - yum-caching-nameserver
diff --git a/roles/common/tasks/x2go-server.yml b/roles/common/tasks/x2go-server.yml
index c9c3758..c68429d 100644
--- a/roles/common/tasks/x2go-server.yml
+++ b/roles/common/tasks/x2go-server.yml
@@ -9,10 +9,11 @@
     name:
       - x2goserver
       - x2goserver-xsession
-      - x2gobroker-daemon
+      - x2goserver-printing
+      - cups-x2go
     state: present
   when:
-    - ansible_os_family == "Debian"
+    - ansible_facts.os_family == "Debian"
     - "groups['x2go_server']|string is search(inventory_hostname)"
   tags:
     - x2g--server
diff --git a/upgrade.yml b/upgrade.yml
index 9674db6..60f3488 100644
--- a/upgrade.yml
+++ b/upgrade.yml
@@ -6,21 +6,21 @@
 
    - name: Update packages list
      apt: update_cache=yes
-     when: ansible_os_family == 'Debian'
+     when: ansible_facts.os_family == 'Debian'
 
    - name: List packages to upgrade (1/2)
      shell: aptitude -q -F%p --disable-columns search "~U"
      register: updates
      changed_when: False
-     when: ansible_os_family == 'Debian'
+     when: ansible_facts.os_family == 'Debian'
 
    - name: List packages to upgrade (2/2)
      debug: msg="{{ updates.stdout_lines | count }} packages to upgrade ({{ updates.stdout_lines | join(', ') }})"
-     when: (ansible_os_family == 'Debian' and updates.stdout_lines)
+     when: (ansible_facts.os_family == 'Debian' and updates.stdout_lines)
 
    - name: Upgrade packages
      apt: upgrade=safe
-     when: ansible_os_family == 'Debian'
+     when: ansible_facts.os_family == 'Debian'
 
    - name: Check what the new version is
      shell:  lsb_release -r | awk '{print $2}'
@@ -43,11 +43,11 @@
 
 #   - name: list services to restart (3/3)
 #     debug: msg="{{ services.stdout_lines | count }} services to restart ({{ services.stdout_lines | join (", ") }})"
-#     when: (ansible_os_family == 'Debian' and services.stdout_lines)
+#     when: (ansible_facts.os_family == 'Debian' and services.stdout_lines)
 
 #   - name: list services to restart (2/3)
 #     debug: msg="{{ services.stdout_lines | count }} services to restart ({{ services.stdout_lines | join (", ") }})"
-#     when: (ansible_os_family == 'Debian' and services.stdout_lines)
+#     when: (ansible_facts.os_family == 'Debian' and services.stdout_lines)
 
    - name: cache cleanup
      shell: apt-get autoclean