feat: update apt upgrade tasks to conditionally refresh cache based on apt_update variable

roles/ansible_dependencies-bookworm/tasks/main.yml

@@ -29,7 +29,7 @@
 - name: apt upgrade
   apt:
     upgrade: "{{ apt_upgrade_type }}"
-    update_cache: true
+    update_cache: "{{ not (apt_update | default(true) | bool) }}"
     dpkg_options: "{{ apt_upgrade_dpkg_options | join(',') }}"
   when: apt_upgrade|bool
   tags:

roles/ansible_dependencies-bullseye/tasks/main.yml

@@ -32,7 +32,7 @@
 - name: apt upgrade
   apt:
     upgrade: "{{ apt_upgrade_type }}"
-    update_cache: true
+    update_cache: "{{ not (apt_update | default(true) | bool) }}"
     dpkg_options: "{{ apt_upgrade_dpkg_options | join(',') }}"
   when: apt_upgrade|bool
   tags:

roles/ansible_dependencies-trixie/tasks/main.yml

@@ -56,7 +56,7 @@
 - name: Upgrade packages
   ansible.builtin.apt:
     upgrade: "{{ apt_upgrade_type | default('safe') }}"
-    update_cache: true
+    update_cache: "{{ not (apt_update | default(true) | bool) }}"
     dpkg_options: "{{ (apt_upgrade_dpkg_options | default(['force-confdef','force-confold'])) | join(',') }}"
   when: (apt_upgrade | default(false)) | bool
   tags: [ansible-dependencies]

roles/ansible_dependencies-ubuntu-noble/tasks/main.yml

@@ -32,7 +32,7 @@
 - name: apt upgrade
   apt:
     upgrade: "{{ apt_upgrade_type }}"
-    update_cache: true
+    update_cache: "{{ not (apt_update | default(true) | bool) }}"
     dpkg_options: "{{ apt_upgrade_dpkg_options | join(',') }}"
   when: apt_upgrade|bool
   tags:

roles/ansible_dependencies/tasks/main.yml

@@ -32,7 +32,7 @@
 - name: apt upgrade
   apt:
     upgrade: "{{ apt_upgrade_type }}"
-    update_cache: true
+    update_cache: "{{ not (apt_update | default(true) | bool) }}"
     dpkg_options: "{{ apt_upgrade_dpkg_options | join(',') }}"
   when: apt_upgrade|bool
   tags:

roles/common/tasks/apt.yml

@@ -196,7 +196,9 @@
 - name: (apt.yml) apt upgrade
   ansible.builtin.apt:
     upgrade: "{{ apt_upgrade_type }}"
-    update_cache: true
+    # Cache refresh happens in the apt update task above.
+    # Keep fallback refresh only if apt_update is disabled.
+    update_cache: "{{ not (apt_update | bool) }}"
     dpkg_options: "{{ apt_upgrade_dpkg_options | join(',') }}"
   when: apt_upgrade|bool
   tags:

roles/common/tasks/caching-nameserver.yml

@@ -28,7 +28,7 @@
 - name: (caching-nameserver.yml) upgrade
   ansible.builtin.apt:
     upgrade: "{{ apt_upgrade_type }}"
-    update_cache: true
+    update_cache: "{{ not (apt_update | bool) }}"
     dpkg_options: "{{ apt_upgrade_dpkg_options | join(',') }}"
   when:
     - ansible_facts["distribution"] == "Debian"