From 8a7ab5dfeabda5068debb899bdd481e9b87fe60b Mon Sep 17 00:00:00 2001
From: Christoph <ckubu@oopen.de>
Date: Fri, 9 Feb 2024 02:09:43 +0100
Subject: [PATCH] create_opendkim_key.sh: fix error in case of only create DKIM
 key, but not updating DNS server.

---
 create_opendkim_key.sh | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/create_opendkim_key.sh b/create_opendkim_key.sh
index 89c9c3c..07e063c 100755
--- a/create_opendkim_key.sh
+++ b/create_opendkim_key.sh
@@ -861,13 +861,16 @@ fi # if $_create_delegation
 
 # - Check if zonefile creation is needed
 # -
-for _server in ${dns_dkim_zone_slave_server_arr[@]} ; do
-   if [[ -z "$(dig +short @$_server ${update_zone}. NS)" ]] ; then
-      _create_dkim_zone=true
-      break
-   fi
-done
-if ! $_create_dkim_zone && [[ -z "$(dig +short @$dns_dkim_zone_master_server +short ${update_zone}. NS)" ]] ; then
+if $update_dns ; then
+   for _server in ${dns_dkim_zone_slave_server_arr[@]} ; do
+      if [[ -z "$(dig +short @$_server ${update_zone}. NS)" ]] ; then
+         _create_dkim_zone=true
+         break
+      fi
+   done
+fi
+if ! $_create_dkim_zone && $update_dns \
+   && [[ -z "$(dig +short @$dns_dkim_zone_master_server ${update_zone}. NS)" ]] ; then
    _create_dkim_zone=true
 fi